New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support '--maximum-failed-tests' to abort test run when failure threshold is reached #4238

Merged

Evangelink merged 67 commits into microsoft:main from Youssef1313:max-failed

Dec 11, 2024

Member

Youssef1313 commented Dec 4, 2024

Fixes #3496


          Support '--max-failed-tests' to abort test run when failure threshold…

12520ce

… is reached

Youssef1313 requested review from MarcoRossignoli and Evangelink as code owners

December 4, 2024 13:55

Youssef1313 marked this pull request as draft

December 4, 2024 13:55

microsoft-github-policy-service bot added Area: MTP Type: Feature labels

Evangelink reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs Outdated Show resolved Hide resolved

Youssef1313 added 12 commits

December 4, 2024 15:05


          Address review comment

dd480c2


          Remove unused using

e9a4dd8


          Progress

a9e7d32


          Not ideal, and not working even. Keeping in history though

f37ea38


          Fix build error

ce36d36


          Revert

cb1d50a


          Use a capability

0717a76


          Take a different approach

bd63803


          Progress for policies service

46b7577


          Use GetRequiredService

be7c6cc


          Progress

db432ef


          Fix warning

c7b1392

MarcoRossignoli reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs Outdated Show resolved Hide resolved

MarcoRossignoli reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs Outdated Show resolved Hide resolved

MarcoRossignoli reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs Show resolved Hide resolved

MarcoRossignoli reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs Outdated Show resolved Hide resolved

MarcoRossignoli reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs Outdated Show resolved Hide resolved

MarcoRossignoli reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/OutputDevice/OutputDeviceManager.cs Show resolved Hide resolved

MarcoRossignoli reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/Services/PoliciesService.cs Outdated Show resolved Hide resolved

MarcoRossignoli reviewed

View reviewed changes

src/Platform/Microsoft.Testing.Platform/Services/TestApplicationResult.cs Outdated Show resolved Hide resolved

Evangelink removed the Type: Feature label

Youssef1313 added 2 commits

December 6, 2024 11:50


          Progress

624f86f


          Progress

5ef6a17

Youssef1313 added 13 commits

December 9, 2024 13:08


          Fix one more build error

7b5b396


          Fix PublicAPI.Unshipped.txt

8ec5e06


          Rename capability on MSTest side

8a23799


          Remove outdated TODO

e0dbaf1


          Rename public method, add test

92f3d8d


          Progress

f4732db

Doc

ef5bdb9


          Small progress

22d846b


          Fix tests

43d3b21


          Remove unused using


          Cleanup

264eb26


          Add comments

f2dfe03


          Add test for MSTest

e7318df

Evangelink previously approved these changes

View reviewed changes

Member

Evangelink left a comment

A few minor updates but looking great overall! Nice job here @Youssef1313

src/Adapter/MSTest.TestAdapter/Execution/ClassCleanupManager.cs Show resolved Hide resolved

src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Show resolved Hide resolved

src/Platform/Microsoft.Testing.Platform/CommandLine/MaxFailedTestsCommandLineOptionsProvider.cs Outdated Show resolved Hide resolved

src/Platform/Microsoft.Testing.Platform/Extensions/AbortForMaxFailedTestsExtension.cs Outdated Show resolved Hide resolved

src/Platform/Microsoft.Testing.Platform/Hosts/TestHostBuilder.cs Show resolved Hide resolved

src/Platform/Microsoft.Testing.Platform/Services/StopPoliciesService.cs Show resolved Hide resolved

src/Platform/Microsoft.Testing.Platform/Services/StopPoliciesService.cs Show resolved Hide resolved


          Address feedback

f134a13

Youssef1313 dismissed Evangelink’s stale review via

f134a13

December 10, 2024 14:14

Youssef1313 added 11 commits

December 10, 2024 15:18


          Fix build error

3d35495


          Progress

529c521


          Fix test

7e56af8


          Fix test

2c1b69a


          Fix formatting

612a94c


          Adjust unit tests per product change

4f3e7d0


          Try to stabilize test

17fb777


          Merge branch 'main' into max-failed

639ba17


          Small fix

ffad719


          Fix test

9e49602


          Merge branch 'main' into max-failed

93edab9

Evangelink approved these changes

View reviewed changes

Member

Evangelink left a comment

Awesome work here @Youssef1313. Let's merge and do a potential follow-up for https://github.com/microsoft/testfx/pull/4238/files#r1878337032

Evangelink merged commit 17e322a into microsoft:main

10 checks passed

Youssef1313 deleted the max-failed branch

December 11, 2024 08:51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels